Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types)!: use kebab-case for type file names #14279

Closed
wants to merge 2 commits into from
Closed

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 4, 2023

Description

fix #13309

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Sep 4, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added the p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) label Sep 4, 2023
@patak-dev patak-dev added this to the 5.0 milestone Sep 4, 2023
@patak-dev
Copy link
Member

My only doubt is if the previous files should still be left in Vite 5 to avoid the breaking change and give more time to others to update.

@bluwy
Copy link
Member Author

bluwy commented Sep 4, 2023

In the camelCase files we could re-export all from the kebab-case files to preserving compat, though I've not tested if extending types still work this way. It should be rather easy to update though, but would be tough for frameworks who want to support both Vite 4 and 5.

Hard to see how this affects downstream though since ecosystem-ci has a lot of existing reds, but I was thinking if it impacts a lot, we can then do the re-export compat for now.

@patak-dev
Copy link
Member

Maybe good to wait to merge this one until ecosystem-ci can give a better picture of how much needs to be updated. It is in the team board as downstream blocker, so we can discuss it there too.

@sapphi-red
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Sep 15, 2023

📝 Ran ecosystem CI: Open

suite result
analogjs ✅ success
astro ✅ success
histoire ❌ failure
ladle ❌ failure
laravel ✅ success
marko ✅ success
nuxt ✅ success
nx ✅ success
previewjs ❌ failure
qwik ✅ success
rakkas ✅ success
sveltekit ✅ success
unocss ✅ success
vite-plugin-pwa ✅ success
vite-plugin-ssr ❌ failure
vite-plugin-react ✅ success
vite-plugin-react-pages ✅ success
vite-plugin-react-swc ✅ success
vite-plugin-svelte ❌ failure
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ❌ failure

@bluwy
Copy link
Member Author

bluwy commented Sep 15, 2023

Looks like this affects vitest and previewjs 😢 There's part of me that really wants TS to fix it instead

@bluwy bluwy mentioned this pull request Oct 13, 2023
4 tasks
@bluwy
Copy link
Member Author

bluwy commented Oct 14, 2023

Closed in favour of #14615

@bluwy bluwy closed this Oct 14, 2023
@sapphi-red sapphi-red deleted the kebab-types branch October 29, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Types files have capitals in them, leading to them being unreferenceable downstream
3 participants