-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types)!: use kebab-case for type file names #14279
Conversation
Run & review this pull request in StackBlitz Codeflow. |
My only doubt is if the previous files should still be left in Vite 5 to avoid the breaking change and give more time to others to update. |
In the camelCase files we could re-export all from the kebab-case files to preserving compat, though I've not tested if extending types still work this way. It should be rather easy to update though, but would be tough for frameworks who want to support both Vite 4 and 5. Hard to see how this affects downstream though since ecosystem-ci has a lot of existing reds, but I was thinking if it impacts a lot, we can then do the re-export compat for now. |
Maybe good to wait to merge this one until ecosystem-ci can give a better picture of how much needs to be updated. It is in the team board as downstream blocker, so we can discuss it there too. |
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
Looks like this affects vitest and previewjs 😢 There's part of me that really wants TS to fix it instead |
Closed in favour of #14615 |
Description
fix #13309
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).